search

CSRT-NTUA / AlgoPlus

AlgoPlus is a C++17 library for complex data structures and algorithms
https://csrt-ntua.github.io/AlgoPlus
Apache License 2.0
141 stars 20 forks source link

Added heap sort algorithm #25

Closed KronoCode closed 5 months ago

spirosmaggioros commented 5 months ago

I need some changes for the commit:

  1. Please use std::vector for your arrays, and use templates as the other files cause the sorting algo's will not be used only on arrays with integers.
  2. If you can make it with Iterators(See merge_sort.h for example) it would be nice, otherwise just make it with vectors and not C-like arrays.
KronoCode commented 5 months ago

I don't see the added value of using an iterator as the indexes here are used to sort the vector as a binary tree.

spirosmaggioros commented 5 months ago

Thank you for your contribution. Please read the CONTRIBUTE.md file in order to complete all the steps before making a pr. This time i completed the steps for you.