search

CSRT-NTUA / AlgoPlus

AlgoPlus is a C++17 library for complex data structures and algorithms
https://csrt-ntua.github.io/AlgoPlus
Apache License 2.0
160 stars 20 forks source link

Added copy constructor and test case for min heap #47

Closed Xoulios closed 1 month ago

Xoulios commented 6 months ago

I think the add copy constructors to all classes issue can be closed now

spirosmaggioros commented 6 months ago

I think there's a library missing for INT_MAX/INT_MIN cause the build is failing. Good thing that we have automatic test running now, in every push to this branch test cases will run automatically and have to pass. I think it's a minor error, you can see in the build process what failed in details(Basically add the climits library)

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.50%. Comparing base (1a9f1af) to head (dba6522). Report is 13 commits behind head on main.

:exclamation: Current head dba6522 differs from pull request most recent head 3f042df. Consider uploading reports for the commit 3f042df to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CSRT-NTUA/AlgoPlus/pull/47/graphs/tree.svg?width=650&height=150&src=pr&token=3SBDRHUQR5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CSRT-NTUA)](https://app.codecov.io/gh/CSRT-NTUA/AlgoPlus/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CSRT-NTUA) ```diff @@ Coverage Diff @@ ## main #47 +/- ## ========================================== - Coverage 97.69% 97.50% -0.19% ========================================== Files 85 91 +6 Lines 3036 3249 +213 Branches 494 526 +32 ========================================== + Hits 2966 3168 +202 - Misses 70 81 +11 ``` | [Files](https://app.codecov.io/gh/CSRT-NTUA/AlgoPlus/pull/47?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CSRT-NTUA) | Coverage Δ | | |---|---|---| | [src/classes/heap/min\_heap.h](https://app.codecov.io/gh/CSRT-NTUA/AlgoPlus/pull/47?src=pr&el=tree&filepath=src%2Fclasses%2Fheap%2Fmin_heap.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CSRT-NTUA#diff-c3JjL2NsYXNzZXMvaGVhcC9taW5faGVhcC5o) | `86.84% <100.00%> (ø)` | | | [tests/heap/min\_heap.cc](https://app.codecov.io/gh/CSRT-NTUA/AlgoPlus/pull/47?src=pr&el=tree&filepath=tests%2Fheap%2Fmin_heap.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CSRT-NTUA#diff-dGVzdHMvaGVhcC9taW5faGVhcC5jYw==) | `100.00% <100.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/CSRT-NTUA/AlgoPlus/pull/47/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CSRT-NTUA)
Xoulios commented 6 months ago

I do not know what keeps failing. Everything seems to be alright on my machine.

spirosmaggioros commented 6 months ago

Can you add some if statements and maybe some more checks for the code? It seems that the coverage dropped 0.12%, so see if you can do something about it otherwise i will look at it

spirosmaggioros commented 1 month ago

This will be closed due to inactivity and a lot of conflicts