CSRT-NTUA / AlgoPlus

AlgoPlus is a C++17 library for complex data structures and algorithms
https://csrt-ntua.github.io/AlgoPlus
Apache License 2.0
141 stars 20 forks source link

update #51

Closed minageus closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.92%. Comparing base (2a422dd) to head (4f33616).

:exclamation: Current head 4f33616 differs from pull request most recent head 37586e6. Consider uploading reports for the commit 37586e6 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CSRT-NTUA/AlgoPlus/pull/51/graphs/tree.svg?width=650&height=150&src=pr&token=3SBDRHUQR5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CSRT-NTUA)](https://app.codecov.io/gh/CSRT-NTUA/AlgoPlus/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CSRT-NTUA) ```diff @@ Coverage Diff @@ ## main #51 +/- ## ======================================= Coverage 89.92% 89.92% ======================================= Files 95 95 Lines 3247 3247 Branches 574 574 ======================================= Hits 2920 2920 Misses 92 92 Partials 235 235 ```
spirosmaggioros commented 2 months ago

Something is wrong with the output i believe. It wasn't but i just fixed the codestyle and i accidentally broke something or i did something wrong with the json files. The only thing that is missing now is 1)some comments(take as reference other header files in src/) and 2)fixing the issue with the get_coeffs() function in the poly_reg.h file located in src/machine_learning/regression/polynomial_regression) To check your code, please compile the poly_reg.py file located at examples/machine_learning/polynomial_regression/ Extra: If you have time you can add in the end of the poly_reg.py file a function to plot the results of the polynomial regression using the results of get_coeffs()(You can see as a reference the lin_reg.py located at examples/machine_learning/linear_regression)