search

CSRT-NTUA / AlgoPlus

AlgoPlus is a C++17 library for complex data structures and algorithms
https://csrt-ntua.github.io/AlgoPlus
Apache License 2.0
141 stars 20 forks source link

Change value type from int64_t to double in graph.h header #52

Open spirosmaggioros opened 1 month ago

spirosmaggioros commented 1 month ago

The graph.h header file has int64_t value types for distances between edges. It need to be changed to double.

adheeshsharma19 commented 1 month ago

Hi, can I work on this issue ?

spirosmaggioros commented 1 month ago

Sure, if you don't know the codestyle we use you can check the README file as well as the other .md files that we have to guide you on how to contribute(the README.md will guide you on any other file you might need). I opened this issue for newcomers to contribute. The issue is that the older version of graph.h file had int64_t value for the distance, thus, the user can't have doubles as a distance value. We have test cases for each commit you do, so if anything is wrong we can see it from there, you don't need to run all the test cases yourself. If you need anything else you can reply to this issue.

adheeshsharma19 commented 1 month ago

Great, thanks for the opportunity. Will go through the mentioned files and try completing it.

spirosmaggioros commented 4 weeks ago

Issue is still open due to inactivity of participants

adheeshsharma19 commented 4 weeks ago

PR raised - https://github.com/CSRT-NTUA/AlgoPlus/pull/53