CSS-Electronics / cancloud

CANcloud - open source telematics platform
Apache License 2.0
48 stars 25 forks source link

package-lock.json should not be included in version control #22

Closed YassineElbouchaibi closed 3 years ago

YassineElbouchaibi commented 3 years ago

package-lock.json should be added to the git ignore.

It causes npm install to install whatever is in it. This includes old versions and packages not in package.json such as electron.

For the time being I delete it on my side before installing.

MatinF commented 3 years ago

Thanks for the feedback, this should be updated now, but let me know if it still does not work as intended. Also updated the version number in the package.json

YassineElbouchaibi commented 3 years ago

Thanks!

I think the actual file should be deleted from the github repo as well.