CSSE1001 / MyPyTutor

Interactive tutorial application for Python3.
Other
7 stars 12 forks source link

Command-W on Mac causes MyPyTutor to quit when the script window is open #139

Closed ShadovvMoon closed 9 years ago

ShadovvMoon commented 9 years ago

This makes me sad :cry:

sapi commented 9 years ago

This is working as designed (or, at least, as MyPyTutor has always worked).

I'm not sure what the original design reason for this was (as I just carried it over from the old version), but if I had to guess, I would suggest that it's to do with idlelib; we use an EditorWindow subclass from that module, but idlelib makes use of a ridiculous number of global variables and so might not like opening and closing.

At this point it's quite a pain to change, sorry. (At the very least, you'd end up with a UI inconsistency, as the visible tests would no longer correspond to any code.)

sapi commented 9 years ago

Oh, and don't worry, it makes me sad too...but that's just Tk!

ShadovvMoon commented 9 years ago

D:

sapi commented 9 years ago

If it makes you feel any better, this is the same as any self-contained app (eg, System Preferences).

On 4 March 2015 at 10:26, Samuel Colbran notifications@github.com wrote:

D:

— Reply to this email directly or view it on GitHub https://github.com/CSSE1001/MyPyTutor/issues/139#issuecomment-77072637.

ShadovvMoon commented 9 years ago

The main annoyance is that it's a separate window (so when I do command-w I just expect the script window to close). Also, when clicking 'Yes' to the save script dialog it closes the program

sapi commented 9 years ago

Yeah, that's all as designed (aka as it's always been). If you close the window (whether you save the script or not), the whole app will go down.

This is the least of the HIG violations on OS X, trust me... :P

On 4 March 2015 at 10:28, Samuel Colbran notifications@github.com wrote:

The main annoyance is that it's a separate window (so when I do command-w I just expect the script window to close). Also, when clicking 'Yes' to the save script dialog it closes the program

— Reply to this email directly or view it on GitHub https://github.com/CSSE1001/MyPyTutor/issues/139#issuecomment-77072922.

ShadovvMoon commented 9 years ago

This is going to drive me insane xD Video linky