search

CSSE1001 / MyPyTutor

Interactive tutorial application for Python3.
Other
7 stars 12 forks source link

Finding Digits in String #171

Closed ironstrider closed 8 years ago

ironstrider commented 8 years ago

Testing correct solution for Finding Digits in String problem causes an error in static analysis on Python 3.5 on OS X, but does not occur in 3.4. Unknown if issue exists on Windows/Unix also.

pjritee commented 8 years ago

Are you reasonably confident this is the only problem suffering from this bug?

ironstrider commented 8 years ago

No. Not until the cause is determined. I think this may be related to the original error that arose when we upgraded to 3.5, which was to do with arguments somehow.

r-portas commented 8 years ago

The same issue happened on a lab machine running Python 3.5

TRManderson commented 8 years ago

Successfully replicated on Ubuntu too. Attempting to diagnose the issue.

TRManderson commented 8 years ago

Python 3.5 removed "starargs" from the abstract grammar of function calls. Becase PEP0448 is included in python 3.5, the ability to have multiple unpackings (ie fn(*args1, *args2)) had to break backwards compatibility. Doing a workaround.

TRManderson commented 8 years ago

The fix in #173 means that nothing that would otherwise be okay is currently broken, but there might be more implications in how we interact with the AST. I'll see if I can find any more, but that solves this issue.

TRManderson commented 8 years ago

Doing a diff on the abstract grammar, it seems that this is the only change that breaks backwards compatibility. All the other changes are adding the new async features.