search

CSSG-Labs / PyNote

Text Editor Written in Python
GNU General Public License v3.0
3 stars 4 forks source link

Added Application class #7

Closed AdamLaine closed 2 years ago

AdamLaine commented 2 years ago

Issue #5 Hopefully I did everything correctly (otherwise tell me what to redo). The application works the same, I tried to leave the original code as unchanged as possible, nothing else to report

PatrickBruso commented 2 years ago

@SamReiCooper This looks good, but I did notice two things. First, you should retain the Tk() call to initialize the tcl/tk interpreter and create the root window. The way you have coded the application still works, because the interpreter is implicitly called when the first text window is created, but it's better to explicitly call it. See this stackoverflow thread for an explanation and a good example of how to call the tk.Tk() root and apply it to the application class.

The second item is that the self.master.title("PyNote") code should go above the comment about the text box. This sets the title for the application and is not part of the code to create the text box. Other than that, everything looks good.

PatrickBruso commented 2 years ago

Merging pull request as this item needs to be finished so we can work on other items. Will add new issues for the two issues noted above.