CSSLint / csslint

Automated linting of Cascading Stylesheets
http://csslint.net
Other
4.77k stars 483 forks source link

Ignore blocks don't forgive syntax errors #660

Open shmax opened 8 years ago

shmax commented 8 years ago

Hi there, I've got a few lines of non-standard CSS I'd like to ignore. Something like this:

   /* csslint ignore:start */
   background-color: $myCustomColor; // syntax error!
   /* csslint ignore:end */

However, this doesn't help; the errors are still let through. I dove into the code a bit, and apparently this is because the ignore stuff is only considered in the "report" function, and not the "error" function. Is this by design, or an oversight? If it's the latter, I'd be happy to open a PR.

Some of you may be considering suggesting that I run CSSLint on the compiled CSS, but this is not a SASS situation; the CSS I'm working with is ultimately consumed by a custom framework (that happens to support SASS-like variables), and is never compiled.

@frvge

frvge commented 8 years ago

Hi, IIRC it was created to prevent errors in the reports from popping up. Syntax errors are different.

So the feature was not meant for your particular use-case.

shmax commented 8 years ago

I've since worked around it (by examining the 'evidence' property of the messages that come back post-lint), but it would be nice if something could be done about this. I think most people would expect a comment cue called "ignore" to ignore without exception, not just some things.