CSSLint / csslint

Automated linting of Cascading Stylesheets
http://csslint.net
Other
4.76k stars 483 forks source link

error while specifying variables in CSS3 ; Expected RBRACE. This rule looks for recoverable syntax error #720

Open avreddy1996 opened 6 years ago

avreddy1996 commented 6 years ago

:root{ --nvctheme-color: #3f1a67; --nvcthemelight-color: #5f259e; } this is the code I am using to define website theme color as a variable but in CSSlint it is showing error ERROR: Expected RBRACE at line 17, col 3. This rule looks for recoverable syntax errors. (errors) Browsers: All

aliceinpalth commented 6 years ago

Experiencing this as well.

adityarao310 commented 6 years ago

Yup, same here

frvge commented 6 years ago

The parser doesn't know how to handle CSS Variables as far as I know.

varunyellina commented 6 years ago

Happens with me too.

Redmega commented 6 years ago

Support for css variables has landed in all major browsers except ie11. csslint should support it!

vrosu commented 6 years ago

Same issue here. Don't know why, but when trying to use / csslint ignore:start / and / csslint ignore:end / I can't get rid of errors inin CodeMirror (uses CSSLint 1.0.4). Has anyone managed to use the ignore to get rid of the css variables errors?

JoniVR commented 6 years ago

@vrosu Nope, same issue as described above, really annoying. Ignoring doesn't seem to help.

hroger1030 commented 6 years ago

Ran into this issue this morning, Visual Studio won't publish css with this error, even though the pages run just fine locally.

This is a 6 month old bug, and it hasn't been addressed. If it is too hard to properly write rules to properly identify this use case, then turn off validation checking for empty rules so you don't break things while you get your logic sorted out.

Kinda irritated that I have to fight with csslint to get work done, it is costing more time than it is saving...

LinearDynamics commented 5 years ago

landed here from a search. Have a WordPress site going and the editor didn't like my variable (expected RBRACE).

BrandonDyer64 commented 5 years ago

Is this still an issue?

hroger1030 commented 5 years ago

yep. Here is lines 1-8 of a css sheet:

:root { --accent1: #777777; --accent2: #cccccc; --Background1: #000000; --Background2: #000044; --Background3: #000055; }

gives the following errors:

Severity Code Description Project File Line Suppression State Error empty-rules (CssLint) Rule is empty. Website D:\SourceCode\test\C# - gc\Website\App_Themes\PageStyle.css 1
Error errors (CssLint) Expected RBRACE at line 3, col 5. Website D:\SourceCode\test\C# - gc\Website\App_Themes\PageStyle.css 3
Error errors (CssLint) Expected RBRACE at line 4, col 5. Website D:\SourceCode\test\C# - gc\Website\App_Themes\PageStyle.css 4
Error errors (CssLint) Expected RBRACE at line 5, col 5. Website D:\SourceCode\test\C# - gc\Website\App_Themes\PageStyle.css 5
Error errors (CssLint) Expected RBRACE at line 6, col 5. Website D:\SourceCode\test\C# - gc\Website\App_Themes\PageStyle.css 6
Error errors (CssLint) Expected RBRACE at line 7, col 5. Website D:\SourceCode\test\C# - gc\Website\App_Themes\PageStyle.css 7

parak80 commented 5 years ago

I have the same problem, it gives no error in appveyor client test but in visual studio where my backend included I see errors like above for my variables.css :root{ --accent-color: #5491db; --nav-back-color:#353b44; ... } Anyone can help please?

BrandonDyer64 commented 5 years ago

@parak80 There's not really anything you can do. It's an issue with CSSLint. This issue has been open for over a year.

Speaking of which, are there any Pull Requests addressing this issue?

frvge commented 5 years ago

https://github.com/CSSLint/parser-lib/pull/248 got opened a few days ago.

shaunrashid commented 5 years ago

Looks like the parser-lib PR is in limbo as the contributor is not working on it anymore. :(

EliasTouil commented 5 years ago

Anything new on this ?

mattiacci commented 5 years ago

I've opened a pull request to fix this, in case we want to avoid #754.

frvge commented 5 years ago

I'm happy to merge it, but I don't have the power to make an official release for neither parser-lib nor csslint itself.

4ist commented 5 years ago

For what it's worth- If my .css files is closed then the .net solution is buildable without the errors

tahaygun commented 5 years ago

WTF!!! We are living in 2019 and still struggling with this? I hate visual studio.

BrandonDyer64 commented 5 years ago

@tahaygun I am equally frustrated, but I don't think this has anything to do with Visual Studio.

tahaygun commented 5 years ago

@BrandonDyer64 probably you are right. I jumped from vscode to visual studio and really hated it.. So I can't afford anything about it. I go crazy every time when I face with a problem.

BrandonWingerAir commented 4 years ago

Also got this error with a WordPress site.

babakmomeni commented 4 years ago

@BrandonWingerAir Could you get rid of this error? I also got this error is my CSS files within WordPress...

codler commented 4 years ago

I'm happy to merge it, but I don't have the power to make an official release for neither parser-lib nor csslint itself.

@nschonni Can you make a release?

Ademord commented 4 years ago

I'm still confused and in need of help for this

cawa-93 commented 4 years ago

@Ademord I have no hope of solving this problem. The last significant commit was made in 2017. Everything looks like the project is abandoned and dead.

sidvenu commented 4 years ago

Codacy, which I think uses CSSLint, has this issue too.

oluwafemi-love commented 4 years ago

I am facing this as well. Probably, I will turn off the CSS Lint. I am tired.

bb010g commented 4 years ago

@nschonni Pinging you, as you're listed in the @CSSLint organization and actively contributing to other linters. Do you know CSSLint's current maintenance status?

Xmetalfanx commented 3 years ago

yeah, using Codacy here for a few projects and one of the few reasons it gets rated lower is due to this issue ... I REALLY didn't expect the issue to be this old and still going

CircuitSacul commented 3 years ago

2021 and this issue is still an issue?

thenexus00 commented 3 years ago

2021 and this issue is still an issue?

Yes, Crazy hey.

GeneralMine commented 3 years ago

Can confirm that's still an issue...

DevWeb13 commented 2 years ago

26/10/2021 Always the issue in codacy...

tomivm commented 2 years ago

15/12/2021 the issue persists in codacy

S0AndS0 commented 2 years ago

For those that land here after a web-search, the following Awk/Bash wrapper script is what I currently use to ignore RBRACE errors related to CSS custom properties;

#!/usr/bin/env bash

_args=( "${@?No arguments provided}" );

awk 'BEGIN {
  delete buffer;
  after_match = 1;
  header_amount = 5;

  pattern_one = "RBRACE";
  pattern_two = ".*--\\w(-|\\w)+:";

  matched_one = 0;
  counter = 0;
}
{
  ## Print header
  if (NR < header_amount) {
    print $0;
    next;
  }

  if (!matched_one) {
    if ($0 ~ pattern_one) {
      # print "## MATCHED PATTERN ONE";
      delete buffer;
      matched_one = 1;
    } else {
      buffer[length(buffer)] = $0;
      if (!length($0)) {
        for (i in buffer) {
          print buffer[i];
        }
        delete buffer;
      }
    }
  } else {
    if ($0 ~ pattern_two) {
      counter++;
    } else if (counter > after_match) {
      counter = 0;
      matched_one = 0;
    }
  }
}' < <(csslint "${_args[@]}");
chris-oliver-getvisibility commented 1 year ago

It's clear that this repository has been abandoned.

Does anybody know if there is a spiritual successor?

S0AndS0 commented 1 year ago

@chris-oliver-getvisibility recently I went on the hunt for alternatives, and it seems stylelint may be able to satisfy the want of CSS (and SCSS) linting... though I've yet to make the time to test it :shrug:

chris-oliver-getvisibility commented 1 year ago

Thanks @S0AndS0 !

linusjf commented 6 months ago

Any updates on this? CSS variables are breaking csslint.

linusjf commented 6 months ago

Dropped the use of csslint from my project. stylelint seems to be the way forward.

Xmetalfanx commented 6 months ago

Dropped the use of csslint from my project. stylelint seems to be the way forward.

i am not even sure (it was at LEAST MONTHS ago or longer) but i think that is what i did here