search

CSSLint / parser-lib

Collection of parsers written in JavaScript
http://www.nczonline.net/
Other
287 stars 82 forks source link

Add support for position: -webkit-sticky #236

Closed toptalo closed 6 years ago

toptalo commented 6 years ago
stubbornella commented 6 years ago

Please separate your stylistic changes into a different PR and resubmit it.

toptalo commented 6 years ago

Is this okay or it will be better to close this PR and make another one for more clean history? With only one change

stubbornella commented 6 years ago

It's fine, what do you think about adding a CSS validation test? Like maybe in this file: https://github.com/CSSLint/parser-lib/blob/0263b2dcf5156ba7fd817e46d567a1917b776b03/tests/css/Validation.js#L1551

toptalo commented 6 years ago

Added validation test

toptalo commented 6 years ago

Thanks!

toptalo commented 6 years ago

Hello @stubbornella, maybe you'll have time to see my other PR (#237, #238, #239)