Closed EarthenSky closed 3 months ago
Whoaaa
Tell ya what, I'll look into then when i work on https://github.com/CSSS/csss-site-frontend/issues/36
wait this is a PR not an issue 🤣
Looks good! Did you test it?
If yes I'll approve
Oh also, can you check if anywhere else in Home.js uses object-cover? Other elements might need the same style prop to fix the aliasing bug
I have not tested it locally, and I'm not exaaaaactly sure how to do so. I tried once following the README, but I had to fight with node dependency hell for a few hours to limited success..... I'll give it a try later tonight, unless you're able to do so.
node dependency hell
💀 bro what happened, if it takes more than 15 mins pls call me and let me help 🙏
I'll test locally, but if you need my help getting set up just LMK
Should just be: npm ci
, then npm run start
Given you have the right version of npm
and node
installed, with nvm
(check README for instructions)
Just tested locally, it fixes it!
bro what happened
Apparently, the installed version of node I had wasn't new enough to install the node version package manager? And so it got into a state where npm would fail if you ran any non-trivial command because the version of npm was up to date but node wasn't. The internet's solution was to just completely re-install node, npm, and everything, and it seems this was somewhat common? I don't remember very well, but I believe I "gave up" around halfway though since I didn't plan on developing with react anyways...
I will hit you up tonight! :sob:
damn that sounds rough 😭
good luck soldier, hit me up if needed
ill approve and merge cuz i love 1 line long PRs
Weird aliasing bug with chrome, see https://stackoverflow.com/questions/74502978/object-fit-cover-gives-pixelated-images-on-chrome for more info
I thought I was going crazy hahaha