search

CSSS / csss-site-frontend

CSSS Website Frontend (2024 - Present)
https://new.sfucsss.org/
GNU Affero General Public License v3.0
6 stars 6 forks source link

Documents Page #59

Closed Nakul727 closed 3 months ago

Nakul727 commented 3 months ago

Close https://github.com/CSSS/csss-site-frontend/issues/49

Hey, this is the documents page, really basic just wanted to commit the work that I did. Also, I was working on the affiliates page and wrote some boilerplate code which I committed because why not. Tell me if you want to remove something or just change it completely because I didn't spend too much time on it. Just didn't want to hold the task for too long so that other people can work on it, which might be better.

Screenshot 2024-08-17 at 11 14 39 PM
Nakul727 commented 3 months ago

I also changed the way footer was exported from the components folder which might cause some merge problems. lmk if you want me to change it back.

Nakul727 commented 3 months ago

Also I think the issue was changed and documents page was assigned to someone else. I already made the page so it will be good if there is no duplicate work. If they already did, then choose the better design :)

EarthenSky commented 3 months ago

Also I think the issue was changed and documents page was assigned to someone else. I already made the page so it will be good if there is no duplicate work. If they already did, then choose the better design :)

I'm not sure if you checked in with @micahdbak, but please do next time, or reach out to myself (& grab the issue by assigning yourself! I think you should have the permissions to do so). If you want a page that someone's already assigned, feel free to ask us too! A lot of the issues haven't been worked on yet, just assigned so people have an idea of what to do.

Ultimately I think this is great, and it luckily seems like @gunmack hadn't started yet, so we're all good with picking your design.

gunmack commented 3 months ago

Looks good, just to confirm I did not start on this

Nakul727 commented 3 months ago

I think it is good to separate the documents and affiliate page issue because I kind of initially told Micah I will do both at the same time. Since this requires a decent amount of change, @gunmack if you want, you can work on the documents page (probably best to discard the code and rewrite with table) and meanwhile, I could focus on the affiliates page. Lmk what you think :)

Nakul727 commented 3 months ago

Accidentally closed it 😅

EarthenSky commented 3 months ago

I think it is good to separate the documents and affiliate page issue

I think what you have is a pretty good first step for both pages! Let’s merge this PR & you can make a new PR for the changes you (or @gunmack) might want to make for either page.

I can fix the two small issues I mentioned later tonight if you haven’t already.

micahdbak commented 3 months ago

(Replaced by https://github.com/CSSS/csss-site-frontend/pull/60)