search

CSU-Radarmet / CSU_RadarTools

A module of independent functions to do precipitation retrievals from polarimetric radar data
GNU General Public License v2.0
88 stars 43 forks source link

Fix setup script and add packaging improvements #57

Closed CAM-Gerlach closed 5 years ago

CAM-Gerlach commented 5 years ago

After running into a bit of trouble building and running on Windows, I was up and running after a few teaks to setup.py and installing the proper compiler versions. However, while I was at it, I figured I'd contribute those fixes back here, and in the process I ended up doing some related cleanup and updating in setup.py as well as a few key additions that should make this ready to go for PyPI, if there is any interest—it certainly should make the project more accessible to newcomers, particularly for students and those newer the field, simplify package and dependency management for users, and increase visibility to reach a wider audience.

Let me know if I can be of further help! I was also thinking of submitting another PR to do some baseline cleanup and standards-conformance issues (fixing crazy mixed line endings and enforcing universal newlines by .gitattributes, HTTPS links, explicit encoding declaration, standardized ISO 8601 dates, a few minor additional packaging improvements, and maybe some conservative linting), if you wouldn't mind. Thanks!

CAM-Gerlach commented 5 years ago

I moved the someone rambling packaging discussion to its own issue, #58 .

tjlang commented 5 years ago

Wow, thank you very much for doing this! Looks good, merging.