CSwala / CSwala-android

An app that is a one-stop destination for all the CS enthusiasts, providing resources like Information scrapping techniques, best YT channels, courses available free-of-cost, etc. & knowledge about every domain and field that exists on the Internet related to Computer Science along with News, Jobs, and Internships opportunities in these domains along with valuable tips and hacks from mentors for a particular domain.

54 stars 51 forks source link

#93 Progress bar Visibility #125

Closed hemant2705 closed 3 years ago

hemant2705 commented 3 years ago

Explanation

There were few places where a progress bar was required. So implemented that Fixes #93

Checklist

[x] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[x] The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
[x] The PR does not contain any unnecessary auto-generated code from Android Studio.
[x] The PR does not break any part of the existing code.
[x] The PR creator have carefully read & adher to the contributing guidelines of the project.
[x] The PR is made to the branch that's called "develop".
[x] The PR is made from a branch that is up-to-date with "develop".

hemant2705 commented 3 years ago

93

GowthamGoush commented 3 years ago

Actually, issue #93 has been assigned to me, and also, this pull request doesn't seem to fulfil the issue.

riturajjain2000 commented 3 years ago

This will not be considered , you can make your own PR @GowthamGoush

GowthamGoush commented 3 years ago

Hey, @hemant2705, it's totally fine since you made this by mistake. I still remember committing similar mistakes when I was new to open-source 😜. Just make sure that you raise an issue before making a pr.

hemant2705 commented 3 years ago

Yeah, actually I understand it's necessary to get assigned first for the issue but earlier one of my issue had been solved by someone while I was in stage of merging the conflicts.(referring #102).

riturajjain2000 commented 3 years ago

Yeah, actually I understand it's necessary to get assigned first for the issue but earlier one of my issue had been solved by someone while I was in stage of merging the conflicts.(referring #102).

@hemant2705 ,It was a beginner issue and you took more than 5 days , that's why😅 Actually there are more participants than issues , and we cannot hold easy issue for this long

GowthamGoush commented 3 years ago

Yeah, actually I understand it's necessary to get assigned first for the issue but earlier one of my issue had been solved by someone while I was in stage of merging the conflicts.(referring #102).

It was a beginner issue and you took more than 5 days , that's why😅 Actually there are more participants than issues , and we cannot hold easy issue for this long

Since I have mentioned email login as well, I was waiting for a fellow contributor to implement it to work on it. In fact, most of my issues are kind of dependent on some features to implement before I could work on them.

GowthamGoush commented 3 years ago

Yeah, actually I understand it's necessary to get assigned first for the issue but earlier one of my issue had been solved by someone while I was in stage of merging the conflicts.(referring #102).

Omg! Just bring it to the notice of our mentors and maintainers. Again that contributor should have been new to open-source.

hemant2705 commented 3 years ago

Yeah, actually I understand it's necessary to get assigned first for the issue but earlier one of my issue had been solved by someone while I was in stage of merging the conflicts.(referring #102).

@hemant2705 ,It was a beginner issue and you took more than 5 days , that's why😅 Actually there are more participants than issues , and we cannot hold easy issue for this long

Actually the fault I did was..I was trying to resolve 2 issues with one pr.. And the second part was generating conflicts.. Hence you can see I closed the that pr. And did it again. As I am very new to vcs and github it will take time to learn up things. Not an issue! 🙃 Looking forward to contribute more and learn😅🙌.