#117 Add Link Preview in Tech Data Activity and Webview also opening in the app only.

CSwala / CSwala-android

An app that is a one-stop destination for all the CS enthusiasts, providing resources like Information scrapping techniques, best YT channels, courses available free-of-cost, etc. & knowledge about every domain and field that exists on the Internet related to Computer Science along with News, Jobs, and Internships opportunities in these domains along with valuable tips and hacks from mentors for a particular domain.

54 stars 51 forks source link

#117 Add Link Preview in Tech Data Activity and Webview also opening in the app only. #145

Closed ANUJAGRAWAL2000 closed 3 years ago

ANUJAGRAWAL2000 commented 3 years ago

Explanation

Checklist

[ ] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[ ] The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
[x] The PR does not contain any unnecessary auto-generated code from Android Studio.
[x] The PR does not break any part of the existing code.
[x] The PR creator have carefully read & adher to the contributing guidelines of the project.
[x] The PR is made to the branch that's called "develop".
[x] The PR is made from a branch that is up-to-date with "develop".

ANUJAGRAWAL2000 commented 3 years ago

@riturajjain2000 Please Check this PR and suggest me changes and merge it.

riturajjain2000 commented 3 years ago

Resolve merge conflicts , and link the issue that is fixed by this PR , Also all the checkboxes must be filled in the PR description , so make changes and fill them accordingly Remove the "Tech data" text from the top, make the background dark as the rest of the app , also see if you can Improve the UI and give spacing between all the Text headings

ANUJAGRAWAL2000 commented 3 years ago

I have resolved the merge conflicts, add this PR solve the issue link is https://github.com/CSwala/CSwala-android/issues/117