Fix #164: Enhance and fix WebActivity as default to display webpages

CSwala / CSwala-android

An app that is a one-stop destination for all the CS enthusiasts, providing resources like Information scrapping techniques, best YT channels, courses available free-of-cost, etc. & knowledge about every domain and field that exists on the Internet related to Computer Science along with News, Jobs, and Internships opportunities in these domains along with valuable tips and hacks from mentors for a particular domain.

54 stars 51 forks source link

Fix #164: Enhance and fix WebActivity as default to display webpages #185

Open GowthamGoush opened 3 years ago

GowthamGoush commented 3 years ago

Explanation

Fixes #164:

Made Job Portal open inside web activity.
Enhanced web activity with a toolbar.
Added option to close, open desktop site and open zoom controls under the toolbar.

Checklist

[x] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[x] The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
[x] The PR does not contain any unnecessary auto-generated code from Android Studio.
[x] The PR does not break any part of the existing code.
[x] The PR creator have carefully read & adher to the contributing guidelines of the project.
[x] The PR is made to the branch that's called "develop".
[x] The PR is made from a branch that is up-to-date with "develop".

GowthamGoush commented 3 years ago

Alright, I'll make those changes. Also, I just failed to mention that the desktop view wasn't working for me even after referring to the documentation and articles. Could you mention some resources, or shall I place a dummy toggle button as of now?

riturajjain2000 commented 3 years ago

Alright, I'll make those changes. Also, I just failed to mention that the desktop view wasn't working for me even after referring to the documentation and articles. Could you mention some resources, or shall I place a dummy toggle button as of now?

OK I'll share the resources

riturajjain2000 commented 3 years ago

Use this String in place of your - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1

Also to check your specific user agent check - https://www.whoishostingthis.com/tools/user-agent/

GowthamGoush commented 3 years ago

Use this String in place of your - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1

Also to check your specific user agent check - https://www.whoishostingthis.com/tools/user-agent/

Extremely sorry for the delay. I followed what you had mentioned above, but still, it didn't work for me. I just wish to know if this not worked for me alone.

riturajjain2000 commented 3 years ago

Use this String in place of your - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1 Also to check your specific user agent check - https://www.whoishostingthis.com/tools/user-agent/

Extremely sorry for the delay. I followed what you had mentioned above, but still, it didn't work for me. I just wish to know if this not worked for me alone.

I did not tried it , but this is the best available solution I found on the net

GowthamGoush commented 3 years ago

As of now, shall I skip this and implement the rest of the features?

riturajjain2000 commented 3 years ago

As of now, shall I skip this and implement the rest of the features?

Ok leave the PR as it is , I'll merge it later