search

CTDbase / exposure-ontology

First pass at repo for Exo
Creative Commons Attribution 4.0 International
3 stars 9 forks source link

adding synonyms to exposure receptor #21

Closed laurenechan closed 3 years ago

laurenechan commented 3 years ago

Including two related synonyms to the term exposure receptor per a request on ECTO. https://github.com/EnvironmentOntology/environmental-exposure-ontology/issues/165

No option to select broad synonym so included 'has_related_synonym'

Hopefully this looks better @matentzn ?

matentzn commented 3 years ago

This is generally ok, but arent these synonyms exact?

laurenechan commented 3 years ago

@matentzn The original issue from Paul stated "In radiation science we use "target" which while actually being broader in some senses is probably better for the sense of the concept. So "exposure target" would be better. An alternative would be "exposure recipient" but this is not great."

I just went with his statement of it being 'broader', but I can adjust to exact if that is preferred. I don't think I fully understand the similarities or differences between the terminologies, they do seem like they could be exact.

matentzn commented 3 years ago

In any case I approve of the PR, if you are happy with the synonym types it's fine. I don't really think it's that important in this case!

diatomsRcool commented 3 years ago

I think its fine to have it as exact in this case

laurenechan commented 3 years ago

@diatomsRcool @matentzn Great, I've updated to exact. I do not have write privileges for ExO currently. Are either of you able to grant me write access and/or to approve and merge this PR?

matentzn commented 3 years ago

I dont!

cjgrondin commented 3 years ago

I think the synonym types are fine in this case, and I've merged the commits.