search

CTDbase / exposure-ontology

First pass at repo for Exo
Creative Commons Attribution 4.0 International
3 stars 9 forks source link

Update exo.owl #30

Closed laurenechan closed 2 years ago

laurenechan commented 2 years ago

Adding exposure stimulus term as a parent for exposure stimulus. Definition based on existing relationship term in RO: https://www.ebi.ac.uk/ols/ontologies/ro/properties?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FRO_0002309&viewMode=All&siblings=false

matentzn commented 2 years ago

You are editing the wrong ontology I think.. @cjgrondin can you make sure to point @laurenechan to the correct edit file?

laurenechan commented 2 years ago

Uh oh.. sorry about that @matentzn @cjgrondin ! I didn't see an exo-edit.owl file in the repo I cloned, did I just miss it?

cjgrondin commented 2 years ago

I usually update both files, exo.obo and exo.owl.

matentzn commented 2 years ago

Manually?

cjgrondin commented 2 years ago

For multiple edits, I update in protege and save in both owl and obo formats. For small edits, like a label change, I do it manually for both files.

laurenechan commented 2 years ago

@cjgrondin did these edits add what you were looking for? Do you typically need to add the term itself to the exo.obo file? I added it here, but can remove if not necessary.

cjgrondin commented 2 years ago

@laurenechan Hi, It looks like you've made 3 commits, 1st added the new term and version change to exo.owl, 2nd updated the definition in that file, and 3rd added the new term and updated version number of exo.obo. Yes, I typically need to add the term itself to the exo.obo file, so I think it looks good, ready to merge.

@matentzn Hi Nico, Do you have any comments to add before the commits get merged?

matentzn commented 2 years ago

You should 

git rm .DS_Store

all the .DS_Store files you have committed and add the to .gitignore

cjgrondin commented 2 years ago

@matentzn Hi, could you please explain in more detail? I'm still on the git learning-curve. My limited understanding of this is that DS_Store files were created and committed when the updates were made and copied from a Mac and these need to be removed (and added to .gitignore ?) without removing the updates to exo.obo and exo.owl. Would this be done before or after the merge?

laurenechan commented 2 years ago

@cjgrondin and @matentzn Hi, I have created a .gitignore directory within ExO and included the three different file names we were getting that need to be ignored. I have also removed those files from the PR so hopefully you see now just 3 major sets of changes, edits to exo.owl, edits to exo.obo, and creation of the .gitignore

matentzn commented 2 years ago

PR looks good @laurenechan @cjgrondin