search

CTDbase / exposure-ontology

First pass at repo for Exo
Creative Commons Attribution 4.0 International
3 stars 9 forks source link

interacts_with removal and replacement with RO version #33

Closed laurenechan closed 2 years ago

laurenechan commented 2 years ago

Adding RO import to get 'interacts with' term. Removed any dependencies on old ExO 'interacts_with' and deleting the ExO version.

@matentzn can you check this out? Thanks!

matentzn commented 2 years ago

I think this is the edit file? https://github.com/CTDbase/exposure-ontology/blob/master/src/ontology/exo.obo

laurenechan commented 2 years ago

Sorry, I was using that then went looking for a file I could open in Protege to do the edits but obviously wrong pick. In the obo file, how do I add in the RO import needed to get the new term to refer to?

matentzn commented 2 years ago

Oh shoot. You really cant - exo needs to be migrated to ODK to do this stuff and I cant do it for a while to come.

Do this:

  1. rename the relation as you did (drop import)
  2. Add a label to http://purl.obolibrary.org/obo/RO_0002434 which is exactly the same as in RO.

Thats all. We need to deal with Exo when it becomes more clear what the strategy is.

laurenechan commented 2 years ago

@matentzn I may need more guidance on this... were those the edits you intended to see?

laurenechan commented 2 years ago

@matentzn did we decide this PR can be merged? Even with the weird file changes (exposure stimulus disappearing...)? Still working to figure out write access (@diatomsRcool let us know what you figure out) but wanted to make note of our plan

matentzn commented 2 years ago

No, definitely not, these are not just weird, these are really destructive. Can you determine if the stimulus term that is lost should be lost - or should actually be added to the edit file? Similar, the two lost synonyms.