CTPUG / wafer

A wafer-thin web application for running small conferences. Built using Django.
ISC License
48 stars 27 forks source link

Stop using django.contrib.sites #369

Open stefanor opened 7 years ago

stefanor commented 7 years ago

It's annoying, and we never put more than one conference in an install.

Let's just go with CONFERENCE_NAME in settings, and get rid of our use of the sites framework.

hodgestar commented 7 years ago

Isn't sites required for generating absolute URLs?

stefanor commented 7 years ago

Right. It isn't in normal cases, but it is in things that happen outside an http request/response cycle (e.g. batch emails)

hodgestar commented 7 years ago

Would static site generation need this?

I'm not against removing django.contrib.sites -- it is an annoying extra step during set up -- just trying to think about things we'd need to fix.

drnlm commented 7 years ago

The static site generation doesn't need django.contrib.sites out the box - it tries to generate relative links everywhere. Some of our renderers may use it (I haven't checked), but those should be easy to fix.

We have at least the following bits that currently require django.contrib.sites: