If the language list in settings is left at the default in the settings file, the default value in the database is set to '()', while the list of legal choices is empty. This results in the individual talk admin form being somewhat annoying to use, - unless the language field is explicitly deleted, the admin form will error out with "Select a valid choice. () is not one of the available choices." when a change is made.
This change sets the default to None in this case, which is more appropriate behaviour.
We could also change the default for WAFER_TALK_LANGUAGES to be None in the settings file, but there is value in keeping the hint that this should be a tuple there.
terceiro
commented
3 years ago
If the language list in settings is left at the default in the settings file, the default value in the database is set to '()', while the list of legal choices is empty. This results in the individual talk admin form being somewhat annoying to use, - unless the language field is explicitly deleted, the admin form will error out with "Select a valid choice. () is not one of the available choices." when a change is made.
This change sets the default to None in this case, which is more appropriate behaviour.
We could also change the default for WAFER_TALK_LANGUAGES to be None in the settings file, but there is value in keeping the hint that this should be a tuple there.