CTPUG / wafer

A wafer-thin web application for running small conferences. Built using Django.
ISC License
46 stars 27 forks source link

icalendar 5.0 breaks the tests #655

Closed drnlm closed 1 year ago

drnlm commented 1 year ago

With icalendar 5.0, the test_ics_view test fails with

File "/home/runner/work/wafer/wafer/wafer/schedule/tests/test_views.py", line 1526, in test_ics_view
20
    self.assertEqual(event['dtstart'].params['value'], 'DATE-TIME')
21
  File "/opt/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/site-packages/icalendar/caselessdict.py", line 40, in __getitem__
22
    return super().__getitem__(key.upper())
23
KeyError: 'VALUE'

but it works fine with 4.1

There's nothing obvious in the icalendar changelog about this behaviour change, so more investriagtion is needed.

hodgestar commented 1 year ago

Odd. What is in event['dtstart'].params?

drnlm commented 1 year ago

It's contains some metadata about the ical record - the test uses as part of the test that times are exported correctly.