Closed rwatson closed 2 years ago
Well the varargs ABI difference still exists, so printf calls will still be broken. If you want to hard-code the new ABI you can, though https://github.com/CTSRD-CHERI/cheribsd-ports/blob/main/devel/llvm-base/files/wrapper.sh.in has the logic to copy for detecting which version to use.
Well the varargs ABI difference still exists, so printf calls will still be broken. If you want to hard-code the new ABI you can, though https://github.com/CTSRD-CHERI/cheribsd-ports/blob/main/devel/llvm-base/files/wrapper.sh.in has the logic to copy for detecting which version to use.
Change made.
Hybrid still needs it too, it changes how capabilities are passed as variadic arguments there
I fixed it to use var-args on morello hybrid as well, so should be good to go now.
Seems fine to me now so long as we don't care about supporting systems with the old ABI
I think we probably don't care about those systems at this point TBH.
Agreed. I think our policy should probably be that we don’t support pre-22.05 releases at this point.
With the recent shift to a proper thread-local storage ABI for Morello purecap code,
ccc
no longer needs to request emulated TLS.