search

CTSRD-CHERI / cheribsd-ports

FreeBSD ports tree adapted for CheriBSD.
https://CheriBSD.org
Other
5 stars 11 forks source link

security/afl++/ Add patch to build on CheriBSD #140

Closed elisehaldane closed 4 months ago

elisehaldane commented 5 months ago

AFL++ uses implicit checks with uname -m, then explicit user-supplied arguments to control the build. If the host returns a different (ARM64) machine string to the one expected in the GNUmakefile, then AFL++ will clone and try to build the Unicorn Engine even when the user passes NO_UNICORN_ARM64=1. One simple fix is to catch both arm64 and aarch64 instead.

This patch was tested on CheriBSD 23.11 with:

make distrib NO_UNICORN_ARM64=1
kwitaszczyk commented 5 months ago

Could you change "security/afl++/" to "security/afl++:" in the commit message, and break lines, as stated in [1]? Also, note that Markdown isn't rendered in commit messages at GitHub.

[1] https://docs.freebsd.org/en/articles/committers-guide/#port-commit-message-formats

kwitaszczyk commented 5 months ago

The port should set NO_UNICORN_ARM64=1 in Makefile by default when building for arm64.