search

CTSRD-CHERI / cheribsd-ports

FreeBSD ports tree adapted for CheriBSD.
https://CheriBSD.org
Other
5 stars 11 forks source link

Fixes for math/gmp compiling under CheriABI. #60

Closed gcjenkinson closed 1 year ago

gcjenkinson commented 1 year ago

Fixes to math/gmp initially my focus is getting something that allows the v8 build to progress. Some points of discussion:

1) The relative merits of patching configure or running autoreconf on a patched configure.ac.

2) How to make this work for both hybrid and pure cap ABIs.

kwitaszczyk commented 1 year ago

As of today, we use a single file for CHERI/CheriBSD-related changes - files/cheribsd.patch (e.g., https://github.com/CTSRD-CHERI/cheribsd-ports/blob/main/lang/perl5.32/files/cheribsd.patch). Could you generate a single patch with the changes?

Additionally, I usually create a GitHub fork in the CTSRD-CHERI organisation, make fixes there, generate a patch from the fork and add the generated patch with a reference to the fork in a commit log in CheriBSD ports. This way we can track particular changes in a project that we patch, have a more granular commit log within that project and have an easier way to possibly upstream these changes. It's not required here but it would be great to do it, if you have time.