search

CTSRD-CHERI / cheribsd-ports

FreeBSD ports tree adapted for CheriBSD.
https://CheriBSD.org
Other
5 stars 11 forks source link

Fix string underread in Alpine #78

Closed bacam closed 5 months ago

bacam commented 1 year ago

Fixes crash after sending mail on Morello

kwitaszczyk commented 6 months ago

@bacam Thanks for working on this. Could you rename mail/alpine/files/patch-imap_src_c-client_nntp.c to mail/alpine/files/cheribsd.patch? It would help us to keep track of internal patches. Also, could you change the commit message to prepend the first line with "mail/aline: ". That's the commit message format from FreeBSD ports that we follow and that is helpful in reviewing the repository history later.

[1] https://docs.freebsd.org/en/articles/committers-guide/#port-commit-message-formats

jrtc27 commented 6 months ago

Or take the upstream patch directly (filtering out the version hunk)? https://repo.or.cz/alpine.git/commitdiff/3d6c5540c8c2f4d01331de13e52790e5d7b6ac49

bacam commented 5 months ago

Renamed, and the commit message changed. I've kept the original patch - it's the same as the upstream except for a bit of line number and version noise.

kwitaszczyk commented 5 months ago

Thank you! I'll rebuild packages for dev in the following week. We have to update the ABI we use first.