hw/net: e1000e: Clear ICR on read when using non MSI-X interrupts

CTSRD-CHERI / qemu

QEMU with support for CHERI

Other

54 stars 28 forks source link

hw/net: e1000e: Clear ICR on read when using non MSI-X interrupts #246

Open ma1thew opened 9 months ago

ma1thew commented 9 months ago

Backported from upstream QEMU; without this CheriBSD will hang during boot if an e1000e adapter is attached.

In section 7.4.3 of the 82574 datasheet it states that

"In systems that do not support MSI-X, reading the ICR
 register clears it's bits..."

Some OSes rely on this.

jrtc27 commented 9 months ago

I'm not opposed to backporting bug fixes, but I do wonder what your use case is for using an e1000e with CheriBSD. What's wrong with virtio-net-{device,pci} (which cheribuild uses)?

Also, please pass -x to git cherry-pick so it's very clear this is a cherry-pick, and which commit exactly.