JOSS review - Githubissues

CTU-Bern / presize

Precision Based Sample Size Calculation

https://ctu-bern.github.io/presize/

GNU General Public License v3.0

15 stars 13 forks source link

JOSS review #64

Closed aghaynes closed 3 years ago

aghaynes commented 3 years ago

This covers changes requested by the JOSS reviewers (see #61)

Still to do - ~~- [ ] testing the shiny app via shinytest~~ there appears to be a bug with shinytest so this will be implemented later

[x] implement additional validation on inputs (see #63)

aghaynes commented 3 years ago

appveyor and travis will be removed (gh actions cover everything) - fails on those CI builds are thus considered irrelevant.

TomKellyGenetics commented 3 years ago

Presume this is waiting for this PR to be merged? https://github.com/aghaynes/presize/pull/4

I'll hold off on reviewing further until the revised manuscript is ready to avoid raising issues already addressed here.

aghaynes commented 3 years ago

@TomKellyGenetics yes indeed. we want to fix the failing CI, although the tests are working locally so figuring out whats wrong is really difficult...