search

CTU-Bern / presize

Precision Based Sample Size Calculation
https://ctu-bern.github.io/presize/
GNU General Public License v3.0
15 stars 13 forks source link

Correct example in README #65

Closed TomKellyGenetics closed 3 years ago

TomKellyGenetics commented 3 years ago

Minor suggestion as part of JOSS review. Review outcome does not depend on this but fixing while I've spotted it.

codecov-io commented 3 years ago

Codecov Report

Merging #65 (a54f359) into master (ded9e2b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files           6        6           
  Lines        1042     1042           
=======================================
  Hits         1024     1024           
  Misses         18       18

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ded9e2b...a54f359. Read the comment docs.

aghaynes commented 3 years ago

@TomKellyGenetics Thanks for the PR. I'm not going to merge it though as this is something that we have changed in PR #64. Hope thats OK! :)

TomKellyGenetics commented 3 years ago

No problem, after I submitted this, I saw it was already discussed in #61.