CTUAvastLab / Mill.jl

Build flexible hierarchical multi-instance learning models.
https://ctuavastlab.github.io/Mill.jl/stable/
MIT License
86 stars 8 forks source link

CompatHelper: bump compat for LearnBase to 0.6, (keep existing compat) #102

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 2 years ago

This pull request changes the compat entry for the LearnBase package from 0.4 to 0.4, 0.6. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov[bot] commented 2 years ago

Codecov Report

Merging #102 (f011bcc) into master (f416a6b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          37       37           
  Lines        1473     1473           
=======================================
  Hits         1323     1323           
  Misses        150      150           
Flag Coverage Δ
unittests 89.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f416a6b...f011bcc. Read the comment docs.

simonmandlik commented 2 years ago

Don't merge until there is a compatible version of MLLabelUtils as well.

racinmat commented 2 years ago

MLLabelUtils has compatible version, but the MLDataPattern does not, we need to wait till they release new version. the needed version is in this diff https://github.com/JuliaML/MLDataPattern.jl/compare/v0.5.5...master

simonmandlik commented 1 year ago

Closing because we got rid of all these packages in favor of https://github.com/JuliaML/MLUtils.jl