search

CTUAvastLab / Mill.jl

Build flexible hierarchical multi-instance learning models.
https://ctuavastlab.github.io/Mill.jl/stable/
MIT License
86 stars 8 forks source link

Test bounds on BagNode #109

Closed pevnak closed 2 years ago

pevnak commented 2 years ago

I have run into this nice bug, where I did

d = BagNode(ArrayNode(randn(Float32, 8,2)), AlignedBags([1:2,3:4,5:6,7:8]))

and subsequent

reflectinmodel

crashes (sometimes), because bugs are not checked. We might consider adding some error / assert to constructor of BagNode

simonmandlik commented 2 years ago

Fixed in https://github.com/CTUAvastLab/Mill.jl/commit/3f7a0497bccd4f732deb46bafb7dcb32a48aba49