Currently, we have LearnBase = "0.4, 0.5" in compat. But we can see only LearnBase=0.4.1 is used in tests
https://github.com/CTUAvastLab/Mill.jl/runs/3668153165 and LearnBase=0.5 can not be used because MLDataPattern.jl supports LearnBase=0.4, but not LearnBase=0.5. In order to prevent many problems once they will actually start supporting it, we should remove it until then. Similar mistake has already caused several headaches to our team, when we added it to compat regardless of https://github.com/JuliaML/MLDataPattern.jl/pull/45.
The code has never ran on LearnBase=0.5 and thus should not be in compat.
cc @SimonMandlik
Currently, we have
LearnBase = "0.4, 0.5"
in compat. But we can see onlyLearnBase=0.4.1
is used in tests https://github.com/CTUAvastLab/Mill.jl/runs/3668153165 andLearnBase=0.5
can not be used becauseMLDataPattern.jl
supportsLearnBase=0.4
, but notLearnBase=0.5
. In order to prevent many problems once they will actually start supporting it, we should remove it until then. Similar mistake has already caused several headaches to our team, when we added it to compat regardless of https://github.com/JuliaML/MLDataPattern.jl/pull/45. The code has never ran onLearnBase=0.5
and thus should not be in compat. cc @SimonMandlik