CTUAvastLab / Mill.jl

Build flexible hierarchical multi-instance learning models.
https://ctuavastlab.github.io/Mill.jl/stable/
MIT License
86 stars 8 forks source link

Stop using LearnBase = 0.5 until it's supported by MLDataPattern #82

Closed racinmat closed 2 years ago

racinmat commented 2 years ago

Currently, we have LearnBase = "0.4, 0.5" in compat. But we can see only LearnBase=0.4.1 is used in tests https://github.com/CTUAvastLab/Mill.jl/runs/3668153165 and LearnBase=0.5 can not be used because MLDataPattern.jl supports LearnBase=0.4, but not LearnBase=0.5. In order to prevent many problems once they will actually start supporting it, we should remove it until then. Similar mistake has already caused several headaches to our team, when we added it to compat regardless of https://github.com/JuliaML/MLDataPattern.jl/pull/45. The code has never ran on LearnBase=0.5 and thus should not be in compat. cc @SimonMandlik