CTUAvastLab / Mill.jl

Build flexible hierarchical multi-instance learning models.
https://ctuavastlab.github.io/Mill.jl/stable/
MIT License
86 stars 8 forks source link

Remove onehot matrix multiplication if the speedup is not large enough #88

Closed racinmat closed 2 years ago

racinmat commented 2 years ago

I think we could remove https://github.com/CTUAvastLab/Mill.jl/blob/master/src/util.jl#L30-L41 since https://github.com/FluxML/Flux.jl/pull/1756 has been merged and the speedup compared to Flux 0.12.8 may not be negligible for our datasets.

simonmandlik commented 2 years ago

Removed in f9d8281b157e756b0c56250e7f148386c1bf9c09