Impose fixed ordering of evaluation inside ProductNodes

CTUAvastLab / Mill.jl

Build flexible hierarchical multi-instance learning models.

https://ctuavastlab.github.io/Mill.jl/stable/

MIT License

86 stars 8 forks source link

Impose fixed ordering of evaluation inside ProductNodes #93

Closed simonmandlik closed 2 years ago

simonmandlik commented 2 years ago

Currently, we're evaluating in ProductModel based on the ordering in samples. This will work as long as the same extractor is used. We should use model ordering instead to make sure we don't learn rubbish in m.W

simonmandlik commented 2 years ago

Solved in https://github.com/CTUAvastLab/Mill.jl/commit/25bd4c90920d1634f367e479971d88870539b043