CU-DBMI / wall-of-software

A list of tools, packages, workflows, resources, and other software developed at or in collaboration with DBMI
https://cu-dbmi.github.io/wall-of-software/
2 stars 6 forks source link

pedbp #6

Closed dewittpe closed 4 months ago

dewittpe commented 4 months ago

Submitter checklist:

Reviewer checklist:

netlify[bot] commented 4 months ago

Deploy Preview for wall-of-software ready!

Name Link
Latest commit 73b8ef82dbe3688e239df3e86d7a3ac5136ad360
Latest deploy log https://app.netlify.com/sites/wall-of-software/deploys/65b956c838f3e70008bd1915
Deploy Preview https://deploy-preview-6--wall-of-software.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dewittpe commented 4 months ago

Just incase - yes, I'm a member of DBMI: SOM Profile and the pedbp package was written up in a news post in December of 2022.

vincerubinetti commented 4 months ago

Thanks for submitting this.

To match with the other designs, please take a look at the image guidelines, particularly the one about backgrounds. The website and printing process will cut the hexagon shape out for you, so it ideally should not be an inherent part of your image. Like this: example

To accept your design, we'd need to get rid of that hexagon cut. (Unless you really feel strongly that the hexagon was already an inherent and necessary part of your design, but in your case I don't think it is.)

If you're open to it, here are some more subjective/aesthetic changes to consider:

dewittpe commented 4 months ago

@vincerubinetti - thank you for the input on the image. I've made some changes and updated this PR. The example image with the full background was very helpful.

One question and place for some discussion - the use of text on the hexsticker for R packages is common. See here the set of R package stickers from the posit store. I'm okay with having a version of the hexsticker without the pedbp name on it for the wall-of-software, but I will also be using a version with the text in other places. It would be nice to have a consistent logo

vincerubinetti commented 4 months ago

Thanks for making that change. Feel free to re-include the text in both images.

This is all still very new, and we're still working on solidifying the guidelines. But I was careful to say "ideally" no text, and only for the website version. The printed version ideally does contain text. Ultimately, with the wide variety of designs we're going to get, we can't really make strict, 100%-of-the-time rules.

Fwiw, we were inspired by this site: http://hexb.in, which seems to be half with-text, half no-text. Also keep in mind the wall isn't restricted to R, packages, or any specific language

For now though, asking for both with-text and no-text images hopefully gives us flexibility to pivot later. For example, in the future, we might do something like this with the website to consistently display the name, where text in the image would be redundant and possibly clashing:

Hopefully, most people already have both text versions (e.g. for posters) and non-text versions (e.g. for favicons) of their logo, so and this won't be a big ask.

Re: the screenshot above, another idea I was toying with:

Keep all the website images no-text, so you can admire the aesthetics of the whole wall, just logos. But then when you hover over any cell, all of the cells have their names pop up and their images dimmed, so you can see everything (names and images) at once on inspection.

dewittpe commented 4 months ago

The idea and use cases for a text and no-text version of the logo are great, and things I had not thought of. Since this is a new logo it's easy for me to make multiple versions. I just reviewed the how the the updated image renders on the page and I want to modify it a bit more - the logo is not centered in the hex image.

This has been a very useful discussion helping me to not only improve this one logo but others that I'll be working on in the near future.

vincerubinetti commented 4 months ago

Regarding your latest commit: Again, it's very important that there be no sign of the hexagon template in the images. Why:

For the website, we might add features or effects that would reveal your hexagon lines. Maybe on hover, the image could morph from a hexagon to a circle. Maybe clicking on the image could open a full screen preview of the software, where we show the logo in square format.

For printing, the cuts they make are not 100% precise, and any printing process will suggest that you to extend colors beyond the cut lines so you don't get random white/unprinted slivers around the edges.

Also, the overlay you have there is dimming the colors a bit.

vincerubinetti commented 4 months ago

Looks good! Thanks for being the first tester of this process. If you have permissions to merge, feel free to do so when ready, otherwise I'll do it in a bit.

dewittpe commented 4 months ago

Thank you @vincerubinetti - sorry for the error with the hexagon outline. I had used it to get an idea about how the image might render and forgot to omit it before pushing changes. Thank you, also, for the feedback on the logo too. It was helpful to get a better logo. I'm a better coder than graphic designer.

vincerubinetti commented 4 months ago

FYI, I moved that extra image to a new /variations folder, where we can keep images that we're not using right now but might use later.