CU-Denver-UQ / LUQ

Learning Uncertain Quantities
Other
1 stars 3 forks source link

Remove compute_r #3

Closed eecsu closed 4 years ago

eecsu commented 4 years ago

Not to include in LUQ. Should just be part of notebooks (and eventually scripts) for now (eventually incorporated into BET).

Also, the command:

print('Average rejection rates for clusters:', rs)

should be changed. I think something like

print('Diagnostic for clusters [sample average of ratios in each cluster]:', rs)

since each r is not technically a rejection rate but rather a relative likelihood update (a re-weighting) to the initial density that can be used to perform rejection sampling.

eecsu commented 4 years ago

In the end, we are leaving the compute_r and generate_kdes in here just to run the examples that are in here. These are not referenced by BET though, so it is fine.