CUAHSI / HydroDesktop

HydroDesktop is a free and open source GIS enabled desktop application that helps you search for, download, visualize, and analyze hydrologic and climate data registered with the CUAHSI Hydrologic Information System. HydroDesktop is part of the legacy CUAHSI toolkit and is not under active development. Click the "releases" link below to download the latest installer for Microsoft Windows.
73 stars 20 forks source link

watersheds not delineating #202

Open xhqiao89 opened 7 years ago

xhqiao89 commented 7 years ago

andrewcantrell[CodePlex]
I am having the a similar problem with boundaries not being delineated. I am using 1.6.13 and for some watersheds it works great but there are a few that constantly give me the reaches but no boundaries. One watershed gives me the reaches but delineates a much smaller watershed within the reaches. Any suggestions?

coobr01 commented 5 years ago

Good Morning, I'm part of the team that maintains the EPA WATERS web service related to watershed delineating. If there are any questions, please feel free to email me at brad.cooper@erg.com or waters_support@epa.gov.

danames commented 5 years ago

Thanks Brad, we're working on fixing this plugin in HydroDesktop. In the meantime, we also encourage users to use our EPA WATERS app that is included in HydroShare at http://apps.hydroshare.org/ (requires creating a free HydroShare account). - Dan


Daniel P. Ames, Ph.D., P.E. Professor, Civil & Environmental Engineering,Brigham Young University, Provo, Utah, USA President, International Environmental Modelling & Software Society Editor-in-Chief, Environmental Modelling & Software http://ceen.et.byu.edu/content/dan-ames http://www.researchgate.net/profile/Daniel_Ames http://scholar.google.com/citations?user=S0GUCeUAAAAJ


On Tue, Mar 12, 2019 at 7:17 AM Brad Cooper notifications@github.com wrote:

Good Morning, I'm part of the team that maintains the EPA WATERS web service related to watershed delineating. If there are any questions, please feel free to email me at brad.cooper@erg.com or waters_support@epa.gov.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CUAHSI/HydroDesktop/issues/202#issuecomment-471996126, or mute the thread https://github.com/notifications/unsubscribe-auth/ADT89Jl3FTnSqdCu-zUjN24HMo_1wKk_ks5vV6j2gaJpZM4O0Nz_ .

coobr01 commented 5 years ago

Hey Dan, I attempted to create a pull request for the fix but don't have permissions on the repo. Via a user email to me, i went ahead and replied to their email which included CUASHI which resulted in help desk # 1357.

But here's the fix (attached .zip contain .cs file) and email content I sent

I’ve attached the corrected code (I tried to create a pull request off the GitHub repo but I don’t have permissions to do so). It switches the code to use HTTPS and updates the method names that changed back in 2016.

It should replace the existing file in \HydroDesktop\Source\Plugins\Plugins.EPADelineation

Someone will need to merge the code into the repo and rebuild the extension.

I believe this will correct several Github issues (#2, 202, 201, 195, maybe 141)

CallWebService.zip

coobr01 commented 5 years ago

Note, we have a native viewer as well called the WATERS GeoViewer - https://www.epa.gov/waterdata/waters-geoviewer it can be used to validate things. In addition, the old school (non-Swagger) web service documentation for the WATERS Web Services are available @ https://www.epa.gov/waterdata/waters-web-services.

danames commented 5 years ago

Thanks, Brad. I've actually merged in your edits and am still getting some errors. Do you have any idea what the source of this error could be? I believe the second part of the error message is part of the return from the web service request. I can dig deeper, but I was just curious if you know about this "Please use feature type ...." error message.

[image: image.png]


Daniel P. Ames, Ph.D., P.E. Professor, Civil & Environmental Engineering,Brigham Young University, Provo, Utah, USA President, International Environmental Modelling & Software Society Editor-in-Chief, Environmental Modelling & Software http://ceen.et.byu.edu/content/dan-ames http://www.researchgate.net/profile/Daniel_Ames http://scholar.google.com/citations?user=S0GUCeUAAAAJ


On Wed, Mar 13, 2019 at 2:42 PM Brad Cooper notifications@github.com wrote:

Note, we have a native viewer as well called the WATERS GeoViewer - https://www.epa.gov/waterdata/waters-geoviewer it can be used to validate things. In addition, the old school (non-Swagger) web service documentation for the WATERS Web Services are available @ https://www.epa.gov/waterdata/waters-web-services.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CUAHSI/HydroDesktop/issues/202#issuecomment-472597406, or mute the thread https://github.com/notifications/unsubscribe-auth/ADT89DwEpJR41yEY9YY-kRGiLUpiCgx2ks5vWWLQgaJpZM4O0Nz_ .

coobr01 commented 5 years ago

Hey Dan, I only see an image placeholder, no image, so I can't see the error messages.

danames commented 5 years ago

I'll add it as an attachment instead of inline...


Daniel P. Ames, Ph.D., P.E. Professor, Civil & Environmental Engineering,Brigham Young University, Provo, Utah, USA President, International Environmental Modelling & Software Society Editor-in-Chief, Environmental Modelling & Software http://ceen.et.byu.edu/content/dan-ames http://www.researchgate.net/profile/Daniel_Ames http://scholar.google.com/citations?user=S0GUCeUAAAAJ


On Thu, Mar 21, 2019 at 3:46 PM Brad Cooper notifications@github.com wrote:

Hey Dan, I only see an image placeholder, no image, so I can't see the error messages.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CUAHSI/HydroDesktop/issues/202#issuecomment-475415539, or mute the thread https://github.com/notifications/unsubscribe-auth/ADT89F8_8jlZx1T4EnBzkKP1E9yWodGXks5vY_3DgaJpZM4O0Nz_ .

coobr01 commented 5 years ago

Good Morning Dan, I'm sorry but I still don't see anything. This is what I see

image

danames commented 5 years ago

OK very strange. It seems my attachments are being blocked. The error says "error searching for watershed. Please use feature type CATCHMENTSP_TOPO for clarity."

This came back from your service (I think) when we sent a request to the delineation service for COMID=23386219 and MEASURE = 30.3719.

Any thoughts?


Daniel P. Ames, Ph.D., P.E. Professor, Civil & Environmental Engineering,Brigham Young University, Provo, Utah, USA President, International Environmental Modelling & Software Society Editor-in-Chief, Environmental Modelling & Software http://ceen.et.byu.edu/content/dan-ames http://www.researchgate.net/profile/Daniel_Ames http://scholar.google.com/citations?user=S0GUCeUAAAAJ


On Fri, Mar 22, 2019 at 5:34 AM Brad Cooper notifications@github.com wrote:

Good Morning Dan, I'm sorry but I still don't see anything. This is what I see

[image: image] https://user-images.githubusercontent.com/1842830/54820250-daa9f700-4c74-11e9-985d-3da8b181b041.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CUAHSI/HydroDesktop/issues/202#issuecomment-475587203, or mute the thread https://github.com/notifications/unsubscribe-auth/ADT89N1G14-iiIVycSnwYwjOEzp5B2Hjks5vZL-qgaJpZM4O0Nz_ .

coobr01 commented 5 years ago

Its hard to tell without seeing your web service request but by looking at https://www.epa.gov/waterdata/navigation-delineation-service I pulled together the below example web service call using your parameters https://ofmpub.epa.gov/waters10/NavigationDelineation.Service?pNavigationType=UT&pStartComid=23386219&pStartMeasure=30.3719&pMaxDistance=15&pAggregationFlag=true&pFeatureType=CATCHMENT&optOutGeomFormat=GEOJSON

danames commented 5 years ago

Thanks, that should help.


Daniel P. Ames, Ph.D., P.E. Professor, Civil & Environmental Engineering,Brigham Young University, Provo, Utah, USA President, International Environmental Modelling & Software Society Editor-in-Chief, Environmental Modelling & Software http://ceen.et.byu.edu/content/dan-ames http://www.researchgate.net/profile/Daniel_Ames http://scholar.google.com/citations?user=S0GUCeUAAAAJ


On Fri, Mar 22, 2019 at 1:47 PM Brad Cooper notifications@github.com wrote:

Its hard to tell without seeing your web service request but by looking at https://www.epa.gov/waterdata/navigation-delineation-service I pulled together the below example web service call using your parameters

https://ofmpub.epa.gov/waters10/NavigationDelineation.Service?pNavigationType=UT&pStartComid=23386219&pStartMeasure=30.3719&pMaxDistance=15&pAggregationFlag=true&pFeatureType=CATCHMENT&optOutGeomFormat=GEOJSON

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CUAHSI/HydroDesktop/issues/202#issuecomment-475756972, or mute the thread https://github.com/notifications/unsubscribe-auth/ADT89PSjbAkuVV1Nv6OU33TbipW0VIWEks5vZTNEgaJpZM4O0Nz_ .