CUAHSI / HydroDesktop

HydroDesktop is a free and open source GIS enabled desktop application that helps you search for, download, visualize, and analyze hydrologic and climate data registered with the CUAHSI Hydrologic Information System. HydroDesktop is part of the legacy CUAHSI toolkit and is not under active development. Click the "releases" link below to download the latest installer for Microsoft Windows.
73 stars 20 forks source link

ConceptKeywords are not written to HydroDesktop database #62

Open xhqiao89 opened 7 years ago

xhqiao89 commented 7 years ago

jirikadlec2[CodePlex]
The HydroDesktop database has a table OntologyConcepts, but this table is empty. the Variables table has a ConceptID foreign key.

Expected behavior is: When a Variable is saved to the database, also save the OntologyConcept information of the variable.

note: This requires expanding HydroDesktop.Interfaces.ObjectModel.Variable by adding the ConceptKeyword property to Variable.

xhqiao89 commented 7 years ago

cuylerfris[CodePlex]
Discussion required - leaving marked as proposed

xhqiao89 commented 7 years ago

mogikanin[CodePlex]
Ok, so you suggest: 1) Populate OntologyConcepts table in default HD database with all concepts that returns by getOntologyTree (ConceptID and Concept fields) 2) Update ConceptDefinition for all available concepts in http://his.cuahsi.org/mastercvreg/ 3) When DownloadPlugin saves Variable into database need to find OntologyConcept by Concept in OntologyConcepts tables and set Variable.ConceptID field.

Also, how ConceptCode should be filled?

xhqiao89 commented 7 years ago

jirikadlec2[CodePlex]
The ConceptID is returned by the response of GetSearchablePaths and getOntologyTree.

http://hiscentral.cuahsi.org/webservices/hiscentral_1_1.asmx/getSearchablePaths

The ConceptDefinition for many of the concepts is available at the CUAHSI variableName controlled vocabulary registry:

http://his.cuahsi.org/mastercvreg/edit_cv11.aspx?tbl=VariableNameCV=821577965

xhqiao89 commented 7 years ago

mogikanin[CodePlex]
Hydrodesktop OntologyConcepts table currently contains ConceptID int ConceptCode string Concept string ConceptDefinition string

HisCentral returns conceptKeyword in GetSeriesCatalogForBox2 response. Is it all available information about OntologyConcept? Or there are another ways to get OntologyConcepts information of variable?