search

CUBoulder-HPCPerfAnalysis / memory

Experiments with memory performance
MIT License
2 stars 7 forks source link

Added dot product into stream.c and results obtained on Dmitry's machine. #1

Closed dmdu closed 9 years ago

jedbrown commented 9 years ago

Thanks! Can you commit the source change that implements Dot and add it to this pull request?

dmdu commented 9 years ago

Updated now.

dmdu commented 9 years ago

Thanks for the feedback. Declared sum properly and now compiling using: make CC=gcc CFLAGS='-O3 -march=native -DTUNED' stream I think I am using the reduction as it should be used. However, I am consistently getting 0 for the duration of the dot product calculation, and I am not entirely sure why.

fdkong commented 9 years ago

As Jed said yesterday, you should use the dot result 'sum' otherwise the compiler will automatically remove your code.

jedbrown commented 9 years ago

Thanks @fdkong. See also this mailing list reply. https://jedbrown.org/lists/archives/hpc-perf-analysis/2015-January/000000.html

dmdu commented 9 years ago

Thanks for these comments! I knew it was something funny like that because the code looked right. Do you still want us to push the updated stream.c or, since it has been merged already, should we add the results file only?

jedbrown commented 9 years ago

Push your version and I'll resolve conflicts in the merge. Also, if you worked with someone on the commit, please add a tag crediting them at the end of the commit message

Helped-by: Valuable Friend <friend@host.tld>

(Reviewed-by is also common.)