CUCWD / edx-platform

The Open edX platform, the software that powers edX!
http://open.edx.org/
0 stars 0 forks source link

Applied `django-require` package updates needed to successfully build the `openedx` Docker image for `maple`. #230

Closed ztraboo closed 7 months ago

ztraboo commented 7 months ago

The original referenced repo https://github.com/edx/django-require?tab=readme-ov-file has been deprecated and moved to the openedx organization on Github.

Details concerning why we merge this commit are here. https://discuss.openedx.org/t/please-update-your-git-urls-for-edx-platform-and-several-other-repos/12387

The tutor recommended patch updates for this did not work when we went to build out the openedx image. I was still receiving this git fetch error when pulling down the django-require repo even after the patch updates recommended by the community below.

image

Moving this to the openedx-dockerfile-post-python-requirements patch as well because it comes after the ./requirements/edx/base.txt call.

hooks.Filters.ENV_PATCHES.add_items([
   (
       "openedx-dockerfile-git-patches-default",
       """
# Fixing this `django-require` package to be from `openedx` org rather than `edx` org.
RUN git config url."https://github.com/openedx/django-require.git".insteadOf "https://github.com/edx/django-require.git"
"""
   ),
   (
       "openedx-dockerfile-post-python-requirements",
       """
# Make sure to install latest version of `openedx/django-require` for the platform to use. Uninstall existing version 1.0.12 first, then reinstall v2.0.0.
RUN pip uninstall -y django-require
RUN pip install -e git+https://github.com/openedx/django-require.git@v2.0.0#egg=openedx-django-require==2.0.0
    ),
    ...
])
ztraboo commented 7 months ago

Merged this without having the tests to pass. Needed this for building out the openedx image.