CUCentralAdvancement / github-docs

Documentation and Best Practices for using GitHub for Advancement Projects
MIT License
2 stars 1 forks source link

Add Basic Cypress Testing To Missing Apps #34

Closed alexfinnarn closed 3 years ago

alexfinnarn commented 3 years ago

Now that there are more Dependabot PRs, it would be nice to have at least one system test per repo. This way, we'd at least know the main features of the app aren't broken with each dependency update. Since the tests broke on giving-frontend, I've just been blindly merging them in and dealing with any issues later.

Adding Cypress via GH Actions is standardized and this shouldn't take too much time. All of these apps are public-facing and require no login.

Do Later:

alexfinnarn commented 3 years ago

Looks like I already have an issue for crowdfunding: https://github.com/CUCentralAdvancement/crowdfunding-cu/issues/21

alexfinnarn commented 3 years ago

Hooray, I was able to get cu-giving testing fixed as well so all deployed apps will have automated testing run before deployments and/or merging PRs.

alexfinnarn commented 3 years ago

I added tests that all passed initially, but it will take some PRs to see if they run reliably or need some more modifications.

alexfinnarn commented 3 years ago

enough PRs have passed on essential-cu and crowdfunding that I will mark this issue as done. The giving-frontend tests probably need updated as the Fund model and search results change to include license plate, write-in funds and other small changes.