Closed JohnYeung-dojjy closed 2 years ago
@JohnYeung-dojjy I changed something on the styling, you may take a look.
And sorry for not stating clearly for task 3. What you did is hide the MusicalNotesIndicator (VPitchIndicator
in code) when the DisplayDrawerButton
is clicked.
But what I mean is that, the MusicalNotesIndicator should show only when DisplayDrawerItemButton
is selected. Like in TimbreDrawer
, we can select instruments and some setting will change corresponding. On DisplayDrawer
, we want to select something to show something to display on screen.
Musical Notes
is just an example (one item). There may be more, but for now just one.
I see, then maybe I can change it as I include an env. class var to store the selected display next week, similar to how the system handles instrument selection.
I see, then maybe I can change it as I include an env. class var to store the selected display next week, similar to how the system handles instrument selection.
You may take a look how I handle this on TimbreDrawer.swift
, TimbreDrawer.swift
TimbreDrawerView.swift
, TimbreDrawerViewModel.swift
, TimbreView.swift
.
added DisplayDrawerView(Model), DisplayDrawerButton (toggle the DisplayDrawerView and VPitchIndicator on click)