search

CUHK-CMD / timbre-visualization-on-ios

Sounds are hard to understand and explain 🎵
https://apps.apple.com/hk/app/soundsgood/id1597764029
0 stars 1 forks source link

added DisplayDrawerView(Model), DisplayDrawerButton #3

Closed JohnYeung-dojjy closed 2 years ago

JohnYeung-dojjy commented 2 years ago

added DisplayDrawerView(Model), DisplayDrawerButton (toggle the DisplayDrawerView and VPitchIndicator on click)

IamMrandrew commented 2 years ago

@JohnYeung-dojjy I changed something on the styling, you may take a look.

And sorry for not stating clearly for task 3. What you did is hide the MusicalNotesIndicator (VPitchIndicator in code) when the DisplayDrawerButton is clicked.

But what I mean is that, the MusicalNotesIndicator should show only when DisplayDrawerItemButton is selected. Like in TimbreDrawer, we can select instruments and some setting will change corresponding. On DisplayDrawer, we want to select something to show something to display on screen.

Musical Notes is just an example (one item). There may be more, but for now just one.

https://user-images.githubusercontent.com/62586450/176924847-f93b96c6-45c5-46cc-8a0b-1881451f2f0a.mov

JohnYeung-dojjy commented 2 years ago

I see, then maybe I can change it as I include an env. class var to store the selected display next week, similar to how the system handles instrument selection.

IamMrandrew commented 2 years ago

I see, then maybe I can change it as I include an env. class var to store the selected display next week, similar to how the system handles instrument selection.

You may take a look how I handle this on TimbreDrawer.swift, TimbreDrawer.swift TimbreDrawerView.swift, TimbreDrawerViewModel.swift, TimbreView.swift.