Closed JohnYeung-dojjy closed 2 years ago
@JohnYeung-dojjy Thanks for ur last commits. There are a few things to keep in mind.
The DisplayDrawerView is ok, we don't need to change it.
But for the RecordingAnalyticsDrawerView, I want it to be the native one, which is the one u made. However, you are using both the drawer. So now it is like a drawer on top of another drawer. So actually u need to remove the DrawerView inside RecordingAnalyticsDrawerView , just leave the content and the native .sheet thing will do the job for u.
And fixing these makes the picker works too!
I helped you cleared these problems in my last commit. You may take a look. And I made part of it more pixel-like the design and reuse some of my existing components and spacings.
right, it looks good to me, but when should we choose to use DrawerView and when to use .sheet()?
right, it looks good to me, but when should we choose to use DrawerView and when to use .sheet()?
Hm, before iOS16, if we need to make a half-screen height drawer, then we need to code our custom view out (DrawerView
)
And for full height drawer, we can stick with the .sheet()
.
File Uses relations: Sound ----> Models/RecordingAnalytics __ \--> Core/RecordingAnalyticsDrawer --> Core/Components/Visual/AnalyticsChart
We May need to increase the default height in DrawerView later