Closed JohnYeung-dojjy closed 2 years ago
@JohnYeung-dojjy Ok, so u will keep working on it? Or i have to review first?
I think these are the only 2 functions that take amplitude data as input? And the rest needs raw data. So I guess you can review it first.
I think these are the only 2 functions that take amplitude data as input? And the rest needs raw data.
So I guess you can review it first.
@JohnYeung-dojjy Ok i can review it later. But I guess it should be fine so can you continue on trying to integrate this to make it work with the audio that we recorded first?
I will also push the chart logic to this branch
Fixed split note logic. Able to analyze splitted note. Will fail when the record start/end at non-silence part.
Threshold of silence need to be reconsider
created the 2 functions, along with some initialized but not-completed functions in AudioViewModel