search

CUHK-CMD / timbre-visualization-on-ios

Sounds are hard to understand and explain 🎵
https://apps.apple.com/hk/app/soundsgood/id1597764029
0 stars 1 forks source link

Split audio by amp #9

Closed JohnYeung-dojjy closed 2 years ago

JohnYeung-dojjy commented 2 years ago

created the 2 functions, along with some initialized but not-completed functions in AudioViewModel

IamMrandrew commented 2 years ago

@JohnYeung-dojjy Ok, so u will keep working on it? Or i have to review first?

JohnYeung-dojjy commented 2 years ago

I think these are the only 2 functions that take amplitude data as input? And the rest needs raw data. So I guess you can review it first.

IamMrandrew commented 2 years ago

I think these are the only 2 functions that take amplitude data as input? And the rest needs raw data.

So I guess you can review it first.

@JohnYeung-dojjy Ok i can review it later. But I guess it should be fine so can you continue on trying to integrate this to make it work with the audio that we recorded first?

JohnYeung-dojjy commented 2 years ago

I will also push the chart logic to this branch

IamMrandrew commented 2 years ago

Fixed split note logic. Able to analyze splitted note. Will fail when the record start/end at non-silence part.

IamMrandrew commented 2 years ago

Threshold of silence need to be reconsider