CUL-DigitalServices / avocet-ui

Open Academic Environment (OAE) Front-End
http://www.oaeproject.org
Educational Community License v2.0
1 stars 1 forks source link

Remove embargo, fix several issues #271

Closed timdegroote closed 10 years ago

timdegroote commented 10 years ago

TL;DR: Fixes https://github.com/CUL-DigitalServices/avocet-ui/issues/266, https://github.com/CUL-DigitalServices/avocet-ui/issues/261 and https://github.com/CUL-DigitalServices/avocet-ui/issues/257

This can't be merged before there is a Hilary counterpart to this PR.

timdegroote commented 10 years ago

Assigning @ucamhal for review.

timdegroote commented 10 years ago

Hilary counterpart can be found at https://github.com/CUL-DigitalServices/avocet-hilary/pull/54

ucamhal commented 10 years ago

Also there's a typo in the commit message of e1a0f9b4e22c89d1c4d51db6afe1eb901d5a2ddf:

Pubicationfile

Also the multiline commit messages should normally have a blank line after the title/summary line. Check out http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

timdegroote commented 10 years ago

Thanks @ucamhal! Added some follow-up.

ucamhal commented 10 years ago

Thanks, merging.