search

CUL-DigitalServices / avocet-ui

Open Academic Environment (OAE) Front-End
http://www.oaeproject.org
Educational Community License v2.0
1 stars 1 forks source link

non-required sentence in red #325

Closed 1ihua closed 9 years ago

1ihua commented 9 years ago

When the line about terms and conditions is unchecked, and hit submit, All texts of terms and conditions are in red, so does the sentence "Your publisher may have an embargo period. If this affects your REF eligibility or funder’s requirements, we will contact you." Should this sentence in normal text color?

screen shot 2014-08-18 at 15 52 54

asd38 commented 9 years ago

Tim improved the error messaging so that the labels in the boxes aren't red anymore but grey. I'm not sure how this particular bit of text would show up, but it's something we can look at during bug bash too.

timdegroote commented 9 years ago

At the moment the terms and conditions text is still red when the checkbox hasn't been checked. I personally don't feel like this is a problem though, @asd38 and @micheleidesmith what do you think?

bertpareyn commented 9 years ago

How much, if any, work still needs to be done for this to be closed?

asd38 commented 9 years ago

The latest form design doesn't have the sentence "Your publisher may have an embargo period. If this affects your REF eligibility or funder’s requirements, we will contact you." anymore, so when the T&C is unticked it only shows the T&C sentence in red, which is in line with the error messages of the other fields and therefore expected behaviour.

asd38 commented 9 years ago

Closing this ticket because it's not an issue anymore since the form text changed.