search

CUL-DigitalServices / avocet-ui

Open Academic Environment (OAE) Front-End
http://www.oaeproject.org
Educational Community License v2.0
1 stars 1 forks source link

'Find out more' link next to Addendum description doesn't line up #346

Closed bertpareyn closed 9 years ago

bertpareyn commented 10 years ago

The 'Find out more' link next to the Addendum description is off by 1 or 2 pixels.

screen shot 2014-09-25 at 10 37 27

All similar links should be checked and fixed.

timdegroote commented 10 years ago

Assigning @bp323 for review.

bertpareyn commented 10 years ago

Removing the class makes the button text larger. Could we fix the source of the problem and also check why other buttons don't have this issue when the class is applied?

bertpareyn commented 10 years ago

Reassigning to @timdegroote for followup

timdegroote commented 10 years ago

Other buttons do have the same result but in their cases it's desired behaviour. The oa-btn-form-help class is meant to be used on buttons next to form field labels which trigger some kind of help. At the moment we only have one ('A note on open access charges') but we used to have more.

Removing the class from this particular button made it look part of the text (size, positioning, etc) which is consistent with the rest of the site. Is this what we want or should the button text be smaller? cc @asd38

asd38 commented 9 years ago

The desired design would be for it to be a slightly smaller font (16px, as it is now), but bottom aligned with the rest of the text. As I understand it, this isn’t as straightforward, unless the font size matches up with the rest of the text (18px)?

What are the other options? I would think whatever the solution is, it would have to be applied to both this ‘Find out more’ link and ‘A note on Open Access charges’. Obviously this is only low priority. Let me know if you just want to talk it through if that’s quicker.

bertpareyn commented 9 years ago

@asd38 @micheleidesmith I don't think talking it through is necessary, dev just needs a decision on this. Reassigning to @micheleidesmith for feedback.

micheleidesmith commented 9 years ago

Please bottom align the 'find out more' text with the grey text to the left. It should shift down by about 2 pixels (I think from checking in Photoshop) to be aligned with the other text.

micheleidesmith commented 9 years ago

Closing issue as this has been merged.