search

CUL-DigitalServices / avocet-ui

Open Academic Environment (OAE) Front-End
http://www.oaeproject.org
Educational Community License v2.0
1 stars 1 forks source link

Terms and conditions should only be shown in the form when administrators have enabled them through the administration UI #349

Closed bertpareyn closed 10 years ago

bertpareyn commented 10 years ago

screen shot 2014-09-25 at 10 53 41

timdegroote commented 10 years ago

Assigning to myself

timdegroote commented 10 years ago

Assigning @bp323 for review.

timdegroote commented 10 years ago

We probably want to wait with merging this as new users would get prompted to accept the terms and conditions as it does in OAE.

bertpareyn commented 10 years ago

@timdegroote We could disable that check in oae.api.js. It'll bring a small customisation but I think that's ok.

bertpareyn commented 10 years ago

Reassigning to @timdegroote for followup

bertpareyn commented 10 years ago

It'll actually need a backend fix. The POST and DELETE requests shouldn't fail and a 419 shouldn't be returned when the user hasn't accepted the terms and conditions. We'll probably need some design input before we want to make this change as it might be more considerable than a UI change. Assigning to @micheleidesmith for feedback.

ucamhal commented 10 years ago

It'll actually need a backend fix. The POST and DELETE requests shouldn't fail and a 419 shouldn't be returned when the user hasn't accepted the terms and conditions.

Feels like the OAE T&C functionality isn't that similar to Avocet's requirements -- we'd be better off not using it. If multi tenancy is still required we could create a separate avocet setting for our T&C text, or just include the text in the repo like the rest of our content.

bertpareyn commented 10 years ago

@ucamhal I think you're right, at the moment we don't know whether the change will be worth it. Closing this as a non-issue for now.