search

CUL-DigitalServices / avocet-ui

Open Academic Environment (OAE) Front-End
http://www.oaeproject.org
Educational Community License v2.0
1 stars 1 forks source link

Made the document icon clickable #357

Closed Coenego closed 9 years ago

Coenego commented 10 years ago

Fix for https://github.com/CUL-DigitalServices/avocet-ui/issues/355

Coenego commented 10 years ago

Assigning to @timdegroote for review

timdegroote commented 10 years ago

Flex unfortunately isn't supported by IE9. It should be possible to achieve the same result though by using display: table;.

Reassigning to @Coenego.

bertpareyn commented 10 years ago

I think it makes sense to think ahead and use flexbox. However the ie-lt10 class should be used to incorporate a fallback approach for IE9.

Coenego commented 10 years ago

Reassigning to @timdegroote for review

bertpareyn commented 10 years ago

Needs to be revisited keeping in mind that ie-lt10 shouldn't be added manually.

Coenego commented 9 years ago

Reassigning to @bp323 for review on follow-up

bertpareyn commented 9 years ago

Reassigning to @Coenego

Coenego commented 9 years ago

I'm not the CSS expert at all, but I assume it doesn't do any harm if we leave the flexbox in there? It might come in handy if a decision is made in the future to make it responsive?

Coenego commented 9 years ago

Reassigning to @bp323

bertpareyn commented 9 years ago

IE9 is experiencing visual issues with this change.

screen shot 2014-10-16 at 11 12 00

Coenego commented 9 years ago

Reassigning to @bp323 for review. Also working in IE9 now.

bertpareyn commented 9 years ago

Verified and merged.